Skip to content

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Oct 16, 2025

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Oct 16, 2025
defaults:
run:
shell: bash -l {0}
continue-on-error: ${{ matrix.allowed-failure }}
Copy link
Contributor

@ianhi ianhi Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might have some unintended consequences.

Just for this PR I'd suggest introducing a failure in the non-flaky pytest to make sure the job still fails. My memory of how this works is that if job will not turn red.

I see now. But beware that i think this means the flaky test will always be green now

- env: "flaky"
python-version: "3.13"
os: ubuntu-latest
allowed-failure: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh wait I was confused by this being below. this impacts the continue-on-error above?

@dcherian
Copy link
Contributor

I think the real oslution here may be to move the pydap backend out to pydap itself, as we have done with the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation Github bots, testing workflows, release automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants