Implement skipna kwarg in xr.quantile #3844
Merged
+69
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @aaronspring! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-07 10:26:25 UTC |
aaronspring
changed the title
added 3 commits
March 7, 2020 10:52
Contributor
Author
|
I am unsure whether I added enough tests. only one test that checks for different values with or without skipna. |
max-sixty
reviewed
Mar 7, 2020
Collaborator
|
This looks great @aaronspring ! Thanks! |
keewis
reviewed
Mar 7, 2020
Co-Authored-By: Maximilian Roos <[email protected]>
Co-Authored-By: keewis <[email protected]>
keewis
approved these changes
Mar 8, 2020
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
thanks, @aaronspring, this looks good to me.
Does it make sense to override / ignore skipna == True if the dtype does not allow missing values?
Collaborator
|
Thanks again @aaronspring ! |
Contributor
|
Yay thanks @aaronspring. |
dcherian
added a commit
to ej81/xarray
that referenced
this pull request
Mar 14, 2020
…e-size * upstream/master: (24 commits) Fix alignment with join="override" when some dims are unindexed (pydata#3839) Fix CFTimeIndex-related errors stemming from updates in pandas (pydata#3764) Doctests fixes (pydata#3846) add xpublish to related projects (pydata#3850) update installation instruction (pydata#3849) Pint support for top-level functions (pydata#3611) un-xfail tests that append to netCDF files with scipy (pydata#3805) remove panel conversion (pydata#3845) Add nxarray to related-projects.rst (pydata#3848) Implement skipna kwarg in xr.quantile (pydata#3844) Allow `where` to receive a callable (pydata#3827) update macos image (pydata#3838) Label "Installed Versions" item in Issue template (pydata#3832) Add note on diff's n differing from pandas (pydata#3822) DOC: Add rioxarray and other external examples (pydata#3757) Use stable RTD image. removed mention that 'dims' are inferred from 'coords'-dict when omit… (pydata#3821) Coarsen keep attrs 3376 (pydata#3801) Turn on html repr by default (pydata#3812) Fix zarr append with groups (pydata#3610) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipnain xr.quantile for speedup #3843isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API