remove autoclose in open_dataset and related warning test #4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@aurghs there's a conflict, would you please fix it? |
# Conflicts: # xarray/backends/api.py
Collaborator
|
@aurghs I think you should check what documentation needs updating beside the doctring. Also this deserves and entry in what's new. |
Collaborator
|
I merge as it has been discussed yesterday in the community meeting. |
toddrjen
pushed a commit
to toddrjen/xarray
that referenced
this pull request
Dec 31, 2020
* remove autoclose in open_dataset and related warning test * black * remove autoclose from open_mfdataset * update what's new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove
autocloseoption fromopen_dataset(both api.py and apiv2.py) and the corresponding testtest_autoclose_future_warningfrom test.pyautoclose=Trueoption was deprecated in #2261 since xarray now uses a LRU cache to manage open file handles.isort . && black . && mypy . && flake8