Skip to content

Convert name to string in label_from_attrs #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2022
Merged

Convert name to string in label_from_attrs #6832

merged 3 commits into from
Jul 26, 2022

Conversation

@Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Jul 26, 2022 •
edited
Loading

Make sure name is a string. Use the same .format method as in _get_units_from_attrs to convert to string.

@Illviljan
Copy link
Contributor Author

Illviljan commented Jul 26, 2022

Well, I fucked up and accidentally added the whats new to main directly. It's there though!

@Illviljan Illviljan mentioned this pull request Jul 26, 2022
Closed
@Illviljan Illviljan merged commit 5a45051 into pydata:main Jul 26, 2022
@Illviljan
Copy link
Contributor Author

Illviljan commented Jul 26, 2022

Thanks @dcherian !

@Illviljan Illviljan deleted the convert_name_2_string branch August 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Success of DataArray.plot() depends on object's history.

2 participants

@Illviljan @dcherian