Skip to content

The Reviewing Process

Jump to bottom
Charlie Hayden edited this page Aug 17, 2025 · 5 revisions

The reviewing process

For your pull request to be merged into the main branch of Pygame Community Edition, and thus make it into future releases, it must first pass the reviewing process. There are two main hurdles to pass:

  1. Your Pull request must obtain the green tick from the Automated Continuous Integration testing. This usually take about 40 minutes to do a full run, failures are noted with the red X of disappointment. You can click on failed testing runs to see if you can work out why the test failed.

  2. You must obtain a set of approving review(s) by the pygame-ce contributor team. The standard path is a minimum of two approving reviews, including at least one from the pygame-ce senior reviewers team. New API PRs are encouraged to get more eyes before merge, when practical. The pygame-ce steering council can also merge PRs below the minimum of two reviews, at their discretion.

Other notes & tips

  • You can't review your own pull request.

  • When to merge? - Other than, does the CI pass? and, does it have enough reviews? I'd say this depends on several factors:

    • the size of the PR
    • number of reviews
    • does it add new API?

    Smaller PRs can generally be merged much more quickly, PRs that affect only comments, style or documentation generally aren't worth that much debate over. However, if somebody has added an entire new submodule; maybe give it a couple of weeks to accumulate opinions.

Clone this wiki locally