Fix possibly-used-before-assignment false negative for type-annotated assignment
#10437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenlyj
added
the
False Negative π¦
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10437 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 176 176
Lines 19140 19140
=======================================
Hits 18352 18352
Misses 788 788
π New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Went through primer results, this probably needs to be refined. will make an update soon |
zenlyj
changed the title
possibly-used-before-assignment false negative for type-annotated assignationpossibly-used-before-assignment false negative for type-annotated assignment
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 646b503 |
mharding-hpe
approved these changes
Jun 24, 2025
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The issue lies in the predicate for variable annotations. It currently checks whether a
Namenode is a child of anAnnAssignnode, but it should also check whether theNamenode is used as type annotation.Closes #10421