-
Couldn't load subscription status.
- Fork 2.1k
Nbqa black #4168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nbqa black #4168
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #4168 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 89 89
Lines 14083 14083
=======================================
Hits 12501 12501
Misses 1582 1582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks @MarcoGorelli ! And all done in one PR 🎉
|
Thank you, sorry for the tediousness of reviewing this kind of change! On the plus side, it's done now 🎉 |
closes #4095
~ 5 notebooks per commit
it's somewhat a matter of choice when/where to turn
fmt: offandfmt: on, but I've tried to make sensible choicesa note on the fixup in
docs/source/notebooks/SMC2_gaussians.ipynb: that notebook originally hadBecause there's a comment after the trailing semi-colon, both
nbqa blackandblack_nbconvertwould transform it toNormally, nbqa is able to preserve these trailing semicolons, but here the extra comment gets in our way. We'd like to address this eventually (nbQA-dev/nbQA#282) but it's not-so-straightfoward to do correctly, so for now we're treating it as a known limitation which can be avoided by putting the comment on a separate line.
Apart from this and the occasional
fmt: offandfmt: onI've added, the rest is just the output from having appliednbqa black