Skip to content

Fix convert_size failure with 1d symbolic vectors #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fix convert_size failure with 1d symbolic vectors #5417

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dadd97
fix on issue 5394
5hv5hvnk Jan 28, 2022
90948a3
new edit
5hv5hvnk Jan 29, 2022
72accb7
changed conver_size
5hv5hvnk Mar 12, 2022
2a6862a
changed conver_size
5hv5hvnk Mar 12, 2022
8a2851c
added ndim<=1 condition
5hv5hvnk Mar 12, 2022
c195048
updated size.ndim==0 condition
5hv5hvnk Mar 12, 2022
18e363a
added elif
5hv5hvnk Mar 14, 2022
f30c6b4
Update shape_utils.py
5hv5hvnk Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymc/distributions/shape_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@ def convert_size(size: Size) -> Optional[StrongSize]:
if size is None:
return None

if isinstance(size, int) or (isinstance(size, TensorVariable) and size.ndim == 0):
size = (size,)
if isinstance(size, int) or (isinstance(size, TensorVariable) and size.ndim==1 or size.ndim==0):
size = tuple(size,)
elif isinstance(size, (list, tuple)):
size = tuple(size)
else:
Copy link
Member

@ricardoV94 ricardoV94 Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? I don't think we have to do anything if it is already a TensorVariable. We could assert it has ndim < 2. but that's about it.

Suggested change
if isinstance(size, int) or (isinstance(size, TensorVariable) and size.ndim==1 or size.ndim==0):
size = tuple(size,)
elif isinstance(size, (list, tuple)):
size = tuple(size)
else:
if isinstance(size, int):
size = tuple(size,)
elif isinstance(size, (list, tuple)):
size = tuple(size)
elif not isinstance(TensorVariable):

Expand Down