Skip to content

Exclude tests from package discovery #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Exclude tests from package discovery #6552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ab4b72
Clean up MANIFEST.in
Armavica Mar 1, 2023
14cf4a0
Remove useless option from setup.py
Armavica Mar 1, 2023
397301b
Exclude tests from package discovery
Armavica Mar 3, 2023
d107a39
Make get_data not look at local files anymore
Armavica Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
recursive-include tests/data *
recursive-include source *
# because of an upload-size limit by PyPI, we're temporarily removing docs from the tarball:
recursive-exclude docs *
include requirements.txt
include *.md *.rst
include scripts/*.sh
Expand Down
10 changes: 2 additions & 8 deletions pymc/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
# limitations under the License.

import io
import os
import pkgutil
import urllib.request
import warnings

Expand Down Expand Up @@ -63,12 +61,8 @@ def get_data(filename):
-------
BytesIO of the data
"""
data_pkg = "tests"
try:
content = pkgutil.get_data(data_pkg, os.path.join("data", filename))
except FileNotFoundError:
with urllib.request.urlopen(BASE_URL.format(filename=filename)) as handle:
content = handle.read()
with urllib.request.urlopen(BASE_URL.format(filename=filename)) as handle:
content = handle.read()
return io.BytesIO(content)


Expand Down
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,10 @@
url=URL,
long_description=LONG_DESCRIPTION,
long_description_content_type="text/x-rst",
packages=find_packages(),
packages=find_packages(exclude=["tests*"]),
# because of an upload-size limit by PyPI, we're temporarily removing docs from the tarball.
# Also see MANIFEST.in
# package_data={'docs': ['*']},
include_package_data=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this exclude other stuff like example NBs or csv files?

Copy link
Member Author

@Armavica Armavica Mar 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no more csv files in pymc (I think they moved to pymc-examples), and if NBs were ever included, I don't think they are not anymore. As far as I can say, building pymc with or without this line creates the same wheel.

classifiers=classifiers,
python_requires=">=3.8",
install_requires=install_reqs,
Expand Down