Skip to content

Add type hints to distribution parameters #6635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Add type hints to distribution parameters #6635

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7397621
test
SangamSwadiK Mar 30, 2023
8bbea35
Merge pull request #1 from SangamSwadiK/add_type_hints
iykat Mar 30, 2023
dc11a99
Merge branch 'pymc-devs:main' into distributions_parameter
iykat Apr 1, 2023
6b4b71f
Add more type hints to distribution parameter
iykat Apr 1, 2023
e92fa8a
Merge branch 'pymc-devs:main' into distributions_parameter
iykat Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions pymc/distributions/continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,13 @@ class HalfNormal(PositiveContinuous):
rv_op = halfnormal

@classmethod
def dist(cls, sigma=None, tau=None, *args, **kwargs):
def dist(
cls,
sigma: Optional[DIST_PARAMETER_TYPES] = None,
tau: Optional[DIST_PARAMETER_TYPES] = None,
*args,
**kwargs,
):
tau, sigma = get_tau_sigma(tau=tau, sigma=sigma)

return super().dist([0.0, sigma], **kwargs)
Expand Down Expand Up @@ -948,7 +954,14 @@ class Wald(PositiveContinuous):
rv_op = wald

@classmethod
def dist(cls, mu=None, lam=None, phi=None, alpha=0.0, **kwargs):
def dist(
cls,
mu: Optional[DIST_PARAMETER_TYPES] = None,
lam: Optional[DIST_PARAMETER_TYPES] = None,
phi: Optional[DIST_PARAMETER_TYPES] = None,
alpha: Optional[DIST_PARAMETER_TYPES] = 0.0,
**kwargs,
):
mu, lam, phi = cls.get_mu_lam_phi(mu, lam, phi)
alpha = pt.as_tensor_variable(floatX(alpha))
mu = pt.as_tensor_variable(floatX(mu))
Expand Down Expand Up @@ -1115,7 +1128,16 @@ class Beta(UnitContinuous):
rv_op = pytensor.tensor.random.beta

@classmethod
def dist(cls, alpha=None, beta=None, mu=None, sigma=None, nu=None, *args, **kwargs):
def dist(
cls,
alpha: Optional[DIST_PARAMETER_TYPES] = None,
beta: Optional[DIST_PARAMETER_TYPES] = None,
mu: Optional[DIST_PARAMETER_TYPES] = None,
sigma: Optional[DIST_PARAMETER_TYPES] = None,
nu: Optional[DIST_PARAMETER_TYPES] = None,
*args,
**kwargs,
):
alpha, beta = cls.get_alpha_beta(alpha, beta, mu, sigma, nu)
alpha = pt.as_tensor_variable(floatX(alpha))
beta = pt.as_tensor_variable(floatX(beta))
Expand Down Expand Up @@ -1243,7 +1265,7 @@ class Kumaraswamy(UnitContinuous):
rv_op = kumaraswamy

@classmethod
def dist(cls, a, b, *args, **kwargs):
def dist(cls, a: DIST_PARAMETER_TYPES, b: DIST_PARAMETER_TYPES, *args, **kwargs):
a = pt.as_tensor_variable(floatX(a))
b = pt.as_tensor_variable(floatX(b))

Expand Down Expand Up @@ -1329,7 +1351,7 @@ class Exponential(PositiveContinuous):
rv_op = exponential

@classmethod
def dist(cls, lam, *args, **kwargs):
def dist(cls, lam: DIST_PARAMETER_TYPES, *args, **kwargs):
lam = pt.as_tensor_variable(floatX(lam))

# PyTensor exponential op is parametrized in terms of mu (1/lam)
Expand Down