Better guesses for why logp has RVs #7663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
better_guess_rvs_in_logp
branch
from
38afb4b to
32609a1
Compare
ricardoV94
force-pushed
the
better_guess_rvs_in_logp
branch
from
32609a1 to
4a0cbd1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7663 +/- ##
==========================================
- Coverage 92.78% 92.70% -0.09%
==========================================
Files 107 107
Lines 18196 18390 +194
==========================================
+ Hits 16884 17049 +165
- Misses 1312 1341 +29
🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestion for why RVs show up in the graph doesn't seem to be the most common: mixing variables from different models. This PR suggests that for the model-related path
transformed_conditional_logp.A more likely explanation is given on the low-level API
conditional_logpfor users that call it directly.📚 Documentation preview 📚: https://pymc--7663.org.readthedocs.build/en/7663/