Skip to content

Fix release_notes_to_discourse script #7862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Fix release_notes_to_discourse script #7862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/publish_release_notes_to_discourse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def format_release_content(config: dict[str, str]) -> tuple[str, str]:

- **Version:** `{config["RELEASE_TAG"]}`
- **Repository:** [{config["REPO_NAME"]}](https://github.com/{config["REPO_NAME"]})
- **Release Page:** [View on GitHub]({config["RELEASE_URL"]})
- **Release Page:** {config["RELEASE_URL"]}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't like the View on Github, no reason to lose info from a readable URL like this

- Note: It may take some time for the release to appear on PyPI and conda-forge.

## 📋 Release Notes
Expand Down Expand Up @@ -105,7 +105,7 @@ def publish_release_to_discourse(config: dict[str, str]) -> bool:
url = f"{config['DISCOURSE_URL']}/posts.json"

try:
response = requests.post(url, headers=headers, data=topic_data)
response = requests.post(url, headers=headers, json=topic_data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha!

response.raise_for_status()

data = response.json()
Expand Down