Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 13, 2024

Is #1086 I realized we had wrong/ outdated stuff that no longer worked.

It may be too costly to run everything in the CI, so maybe this PR will be a one-time cleanup. We can check the runtime once it's fixed.

@ricardoV94
Copy link
Member Author

ricardoV94 commented Nov 13, 2024

Probably a bit too much work. If anybody wants to help out that would be great! See the failing test log for what's failing.

@daniel-s-tccc
Copy link

I'll try to help a bit this week.

@ricardoV94 ricardoV94 marked this pull request as draft February 12, 2025 17:03
@ricardoV94
Copy link
Member Author

@twiecki perhaps this one? I'll rebase it first. Basically we had many docs code examples that wouldn't run, the CI should show which fail.

@twiecki
Copy link
Member

twiecki commented Feb 28, 2025

Let's try!

@ricardoV94
Copy link
Member Author

ricardoV94 commented Feb 28, 2025

@twiecki nothing works today. For some reason I can't get the CI to run the doctest on the docs. I thought it was doing it before. Gonna close this for now. Here is a simpler one we can try? #648

@ricardoV94 ricardoV94 closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs help wanted Extra attention is needed tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants