Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Dec 26, 2024

Closes #1132

The rewrite is not supposed to apply in the case behind the described bug. It was not accounting for uint integer indices, only signed ones :)

Separately but importantly, to run in pure Numba mode in this model we would need to address #1138

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (83c6b44) to head (0787243).
Report is 165 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   82.12%   82.12%   -0.01%     
==========================================
  Files         185      185              
  Lines       48130    48130              
  Branches     8669     8669              
==========================================
- Hits        39527    39525       -2     
- Misses       6438     6439       +1     
- Partials     2165     2166       +1     
Files with missing lines Coverage Δ
pytensor/tensor/rewriting/subtensor.py 90.25% <100.00%> (-0.22%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 8267d0e into pymc-devs:main Dec 31, 2024
62 of 63 checks passed
@ricardoV94 ricardoV94 deleted the fix_numba_rewrite_uint branch April 21, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: sampling with Numba backend fails (BUG IN FGRAPH.REPLACE OR A LISTENER)

2 participants