Skip to content

Conversation

Aarsh-Wankar
Copy link
Contributor

@Aarsh-Wankar Aarsh-Wankar commented Feb 14, 2025

Description

Replaced all instances of output_type_depends_on_input_value with data_dependent_output_shapes for discoverability / standardization. Follows the Aarray API standard for this: https://data-apis.org/array-api/draft/design_topics/data_dependent_output_shapes.html

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1209.org.readthedocs.build/en/1209/

otypes: Sequence["Type"] | None = None

_output_type_depends_on_input_value = False
_data_dependent_output_shapes = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do singular: data_dependent_output_shape, and remove the prefix. We can follow up with an issue to document this in creating an Op, after #1086 is merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes in my new commit; could you please review them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename _output_type_depends_on_input_value

2 participants