Skip to content

Allow passing numpy arrays to transpose #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Allow passing numpy arrays to transpose #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytensor/tensor/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def dimshuffle(self, *pattern):
DimShuffle

"""
if (len(pattern) == 1) and (isinstance(pattern[0], list | tuple)):
if (len(pattern) == 1) and (isinstance(pattern[0], list | tuple | np.ndarray)):
pattern = pattern[0]
ds_op = pt.elemwise.DimShuffle(input_ndim=self.type.ndim, new_order=pattern)
return ds_op(self)
Expand Down
15 changes: 15 additions & 0 deletions tests/tensor/test_variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,21 @@ def test_set_item_error(self):
with pytest.raises(TypeError, match=msg):
x[0] += 5

def test_transpose(self):
X, _ = self.vars
x, _ = self.vals

# Turn (2,2) -> (1,2)
X, x = X[1:, :], x[1:, :]

assert_array_equal(X.transpose(0, 1).eval({X: x}), x.transpose(0, 1))
assert_array_equal(X.transpose(1, 0).eval({X: x}), x.transpose(1, 0))

# Test handing in tuples, lists and np.arrays
equal_computations([X.transpose((1, 0))], [X.transpose(1, 0)])
equal_computations([X.transpose([1, 0])], [X.transpose(1, 0)])
equal_computations([X.transpose(np.array([1, 0]))], [X.transpose(1, 0)])


def test_deprecated_import():
with pytest.warns(
Expand Down
Loading