Don't cancel tests in CI early #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 170 170
Lines 45232 45233 +1
Branches 9626 9626
=======================================
+ Hits 36217 36218 +1
Misses 6797 6797
Partials 2218 2218
|
|
This needs a rebase perhaps? |
aseyboldt
force-pushed
the
no-early-fail
branch
from
c3a2199 to
c6b8031
Compare
ricardoV94
force-pushed
the
no-early-fail
branch
from
c6b8031 to
89b5721
Compare
Armavica
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI currently always stops after the first test failure. This makes it very awkward to debug issues that only appear in the CI online, but not locally.
I think the reason for canceling the tests is that it might reduce CI usage, I'm not really sure this actually is the case if that just means that we need more CI runs...