Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeking to address #193, making type hints for
pt.stack
more accurate.Implementation details
I chose to type hint as TensorLike, defined here as Variable | Sequence[Variable] | npt.ArrayLike. I hope this will address all cases that mypy was complaining about. I also updated the docs and errors accordingly.
Lastly, because there was a case that coerces a list of zero-dim Variables into MakeVector, I also allowed a parallel case of zero-dim numpy arrays to use MakeVector rather than Join and updated a test to cover this case.
Checklist
isort 5.11.5
due to a bug with pre-commit initialization (error with poetry)Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance
Please let me know if you have any feedback!