Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 7, 2023

Modified downstream of aesara-devs/aesara#1399

@ricardoV94 ricardoV94 added enhancement New feature or request graph rewriting aesara downstream PRs that were downstreamed from Aesara labels Feb 7, 2023
@ricardoV94 ricardoV94 requested a review from aseyboldt February 7, 2023 11:42
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #212 (1997812) into main (b8e939e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   80.47%   80.47%           
=======================================
  Files         171      171           
  Lines       45440    45442    +2     
  Branches    11095    11095           
=======================================
+ Hits        36567    36569    +2     
  Misses       6640     6640           
  Partials     2233     2233           
Impacted Files Coverage Δ
pytensor/tensor/rewriting/math.py 86.05% <100.00%> (+0.01%) ⬆️

@ricardoV94 ricardoV94 marked this pull request as draft February 7, 2023 16:34
@ricardoV94
Copy link
Member Author

Have to investigate if the benchmark alert is a fluke

@ricardoV94 ricardoV94 marked this pull request as ready for review April 24, 2023 16:40
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never saw the PatternNodeRewriter before, but LGTM

@ricardoV94 ricardoV94 merged commit 9fd3af7 into pymc-devs:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aesara downstream PRs that were downstreamed from Aesara enhancement New feature or request graph rewriting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants