Fix JAX erfinv failing test #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAX behavior at the boundary changed and no longer returns np.inf like scipy does. Fixed by evaluating at a non-boundary value.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=========================================
Coverage 80.44% 80.44%
=========================================
Files 170 170
Lines 45328 45328
Branches 9687 11069 +1382
=========================================
Hits 36463 36463
Misses 6642 6642
Partials 2223 2223
|
twiecki
approved these changes
Mar 17, 2023
Armavica
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAX behavior at the boundary changed and no longer returns
inflike scipy does, in version 0.4.6Fixed test by evaluating at a non-boundary value.
Closes #241