Skip to content

Fix bug in gradient of set_subtensor #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix bug in gradient of set_subtensor #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytensor/tensor/subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,7 +1902,7 @@ def _sum_grad_over_bcasted_dims(x, gx):
if gx.broadcastable != x.broadcastable:
x_dim_added = gx.ndim - x.ndim
x_broad = (True,) * x_dim_added + x.broadcastable
assert sum(gx.broadcastable) < sum(x_broad)
assert sum(gx.broadcastable) <= sum(x_broad)
axis_to_sum = []
for i in range(gx.ndim):
if gx.broadcastable[i] is False and x_broad[i] is True:
Expand Down
9 changes: 9 additions & 0 deletions tests/tensor/test_subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,6 +1593,15 @@ def just_numeric_args(a, b):
),
)

# Broadcastable leading dim
utt.verify_grad(
f_slice(slice(None, None), slice(1, 3)),
(
np.asarray([0, 1, 2, 3, 4, 5.0])[None, ...],
np.asarray([9, 9.0]),
),
)


class TestIncSubtensor1:
def setup_method(self):
Expand Down