Allow default_output to be any valid Python index #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
default_output
branch
from
87c1e60 to
5071a7d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 80.46% 80.46%
=======================================
Files 170 170
Lines 45412 45408 -4
Branches 11087 11085 -2
=======================================
- Hits 36541 36539 -2
+ Misses 6639 6638 -1
+ Partials 2232 2231 -1
|
ricardoV94
commented
Apr 12, 2023
Comment on lines
-198
to
-200
| raise ValueError(f"{self.op}.default_output should be an int or long") | ||
| elif do < 0 or do >= len(self.outputs): | ||
| raise ValueError(f"{self.op}.default_output is out of range.") |
There was a problem hiding this comment.
I think Python error messages do a good enough job here when indexing is not valid or out of bounds. No need to reinvent the wheel.
michaelosthege
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up in https://discourse.pymc.io/t/m-h-algorithm-with-custom-distribution-with-scipy/11866/4?u=ricardov94
I don't see any reason to break away from Python indexing expectations...