Add JAX support for pt.tri
#302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for these changes
pm.LJKCholesky
userspt.tri
to unpack the cholesky decomposed covariance matrix, so this PR adds support for the underlyingTri
Op
.Implementation details
The only wrinkle is the requirement for static shape args --
jnp.tri
is exactly the same asjnp.arange
in this respect. So I copied the code from thept.arange
jax implementation.Checklist
Major / Breaking Changes
None
New features
First step towards support for LKJCorr in PyMC JAX mode