Some OpenMP tweaks #304
Merged
Some OpenMP tweaks #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
elemwise_minsize
branch
2 times, most recently
from
5980165 to
c5e4e96
Compare
twiecki
reviewed
May 18, 2023
twiecki
reviewed
May 18, 2023
ricardoV94
force-pushed
the
elemwise_minsize
branch
2 times, most recently
from
bfcdd1a to
455dc49
Compare
This was problematic when OpenMP was used in the Elemwise outer loop We add one extra output flag stating whether iteration converged or not. This however breaks Hyp2F1 grad in python mode because it goes beyond the Elemwise limit on number of operands. To fix it we split the grad when on python mode
ricardoV94
force-pushed
the
elemwise_minsize
branch
from
455dc49 to
1225310
Compare
twiecki
approved these changes
May 18, 2023
Only time will tell :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openmp_elemwise_minsizechanges (otherwise it won't have an effect)