Use Dimshuffle for expand_dims
#353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
make_vectorexpand_dims and single element make_vector
ricardoV94
force-pushed
the
use_dimshuffle_instead_of_reshape
branch
from
a2b9083 to
823596b
Compare
This prevents surprises when passing two scalars, which are interpreted differently in the numpy API
ricardoV94
force-pushed
the
use_dimshuffle_instead_of_reshape
branch
from
823596b to
8c782ae
Compare
ricardoV94
changed the title
expand_dims and single element make_vectorexpand_dims
ricardoV94
force-pushed
the
use_dimshuffle_instead_of_reshape
branch
from
8c782ae to
f0bcab8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 156 156
Lines 45397 45400 +3
Branches 11106 11104 -2
=======================================
+ Hits 36497 36502 +5
+ Misses 6694 6691 -3
- Partials 2206 2207 +1
|
michaelosthege
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes more sense as the rest of the codebase prioritizes
dimshuffleover other reshape operations, and most rewrites target those.There is even a rewrite to use expand_dims from reshape when safe.