Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

pymc-devs / pytensor Public

Notifications You must be signed in to change notification settings
Fork 143
Star 539

Code
Issues 301
Pull requests 80
Discussions
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Fix bug where ShapeFeature would create circular shape graph #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ricardoV94 merged 1 commit into pymc-devs:main from ricardoV94:fix_shape_feature_bug

Jan 2, 2024

Merged

Fix bug where ShapeFeature would create circular shape graph #566

ricardoV94 merged 1 commit into pymc-devs:main from ricardoV94:fix_shape_feature_bug

Jan 2, 2024

Conversation 0 Commits 1 Checks 0 Files changed

Uh oh!

There was an error while loading. Please reload this page.

Conversation

Copy link

Member

ricardoV94 commented Dec 28, 2023

Description

Related Issue

Closes local_shape_to_shape_i can make graphs circular #565

Checklist

Checked that the pre-commit linting/style checks pass
Included tests that prove the fix is effective or that the new feature works
Added necessary documentation (docstrings and/or example notebooks)
If you are a pro: each commit corresponds to a relevant logical change

Type of change

New feature / enhancement
Bug fix
Documentation
Maintenance
Other (please specify):

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix bug where ShapeFeature would create circular shape graph

ba39ad0

ricardoV94 added bug

Something isn't working

shape problem graph rewriting labels

ricardoV94 mentioned this pull request

MMM Example hangs in PyTensor >2.18.1 pymc-labs/pymc-marketing#465

Closed

ricardoV94 requested a review from twiecki

January 2, 2024 13:56

twiecki approved these changes

View reviewed changes

ricardoV94 merged commit e180927 into pymc-devs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

twiecki twiecki approved these changes

Assignees

No one assigned

Labels

bug

Something isn't working

graph rewriting shape problem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

local_shape_to_shape_i can make graphs circular

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.