Skip to content

Conversation

lucianopaz
Copy link
Member

@lucianopaz lucianopaz commented Jan 5, 2024

Description

This is a preliminary PR that hopes to address the various issues that came up around pymc with pickling fortran objects. For reference, here, here, here, and there might be more that I'm missing.

This is still a very early draft because I haven't built a reproducible code that shows the error, I hope to be able to do so next week. Once I do, I'll open a proper issue here on pytensor, add unit tests and promote this PR from its draft status.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e180927) 80.92% compared to head (82034ca) 80.92%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #574    +/-   ##
========================================
  Coverage   80.92%   80.92%            
========================================
  Files         162      162            
  Lines       46524    46639   +115     
  Branches    11375    11398    +23     
========================================
+ Hits        37648    37744    +96     
- Misses       6653     6667    +14     
- Partials     2223     2228     +5     
Files Coverage Δ
pytensor/tensor/blas.py 65.19% <100.00%> (+0.17%) ⬆️
pytensor/tensor/blas_scipy.py 85.00% <100.00%> (+2.39%) ⬆️

... and 11 files with indirect coverage changes

@lucianopaz lucianopaz marked this pull request as ready for review January 7, 2024 07:04
@lucianopaz lucianopaz changed the title Use get_blas_funcs instead of storing fortran objects in a dict Don't store fortran objects in ScipyGer tag Jan 7, 2024
@ricardoV94 ricardoV94 added the bug Something isn't working label Jan 7, 2024
@twiecki twiecki marked this pull request as draft January 8, 2024 03:50
@lucianopaz lucianopaz marked this pull request as ready for review January 8, 2024 08:31
@ricardoV94 ricardoV94 merged commit c5b96d9 into pymc-devs:main Jan 8, 2024
@lucianopaz lucianopaz deleted the get_blas_funcs branch January 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Some scipy blas Ops store fortran objects in their tag and cannot be pickled

3 participants