Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 16, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 force-pushed the fix_scan_slices branch 2 times, most recently from 26ffef7 to 9fef604 Compare February 16, 2024 11:50
@ricardoV94 ricardoV94 changed the title DO NOT MERGE: Fix logic to see what was broken Allow more dynamic shape scans to be compiled Feb 16, 2024
Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you also going to fix the [right] return value from the shape_i rewrite in this PR?

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (aad78d5) to head (5ee6c5d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   80.82%   80.83%           
=======================================
  Files         162      162           
  Lines       46805    46815   +10     
  Branches    11439    11442    +3     
=======================================
+ Hits        37832    37842   +10     
  Misses       6710     6710           
  Partials     2263     2263           
Files Coverage Δ
pytensor/tensor/rewriting/basic.py 94.17% <100.00%> (+0.10%) ⬆️

@ricardoV94
Copy link
Member Author

Are you also going to fix the [right] return value from the shape_i rewrite in this PR?

That was not an error actually, I explained in DM on Slack

@ricardoV94 ricardoV94 marked this pull request as ready for review March 4, 2024 11:03
@ricardoV94 ricardoV94 merged commit 62cee00 into pymc-devs:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants