Skip to content

Conversation

tvwenger
Copy link
Contributor

Description

Prevent log10 L_op from upcasting.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@tvwenger
Copy link
Contributor Author

I just copied the logic from log2, but I noticed that, in general, the way that each function handles the type casting in its L_op is wildly different.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (61c15af) to head (1fd0851).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         162      162           
  Lines       46830    46830           
  Branches    11446    11446           
=======================================
  Hits        37857    37857           
  Misses       6710     6710           
  Partials     2263     2263           
Files Coverage Δ
pytensor/scalar/basic.py 80.25% <100.00%> (ø)

@ricardoV94
Copy link
Member

Thanks @tvwenger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants