Skip to content

Conversation

ricardoV94
Copy link
Member

Description

Spinoff from problems found in #691

Also closes #395

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

np.testing.assert_allclose(samples.mean(axis=0), 0.5, 1)


def test_random_choice():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was working fine, but not all branches were being tested so I added them

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (db73461) to head (d697cd6).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   80.83%   80.84%   +0.01%     
==========================================
  Files         162      162              
  Lines       46860    46877      +17     
  Branches    11465    11469       +4     
==========================================
+ Hits        37877    37896      +19     
- Misses       6732     6733       +1     
+ Partials     2251     2248       -3     
Files Coverage Δ
pytensor/compile/mode.py 84.40% <ø> (ø)
pytensor/link/jax/dispatch/random.py 96.33% <100.00%> (+0.27%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@aseyboldt aseyboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@ricardoV94 ricardoV94 merged commit 90da9e6 into pymc-devs:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert patch for index underflow after location 127 when mode=JAX

2 participants