Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 17, 2024

Description

This gets around some limitations in JAX jitting system

This is required for pymc-devs/pymc#7324 to pass

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

This gets around some limitations in JAX jitting system
@ricardoV94 ricardoV94 force-pushed the more_flexible_jax_RVs branch from 1dbe958 to edb72c2 Compare May 17, 2024 13:07
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (d80c0bf) to head (edb72c2).
Report is 210 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         162      162           
  Lines       47019    47026    +7     
  Branches    11504    11507    +3     
=======================================
+ Hits        38018    38025    +7     
  Misses       6750     6750           
  Partials     2251     2251           
Files Coverage Δ
pytensor/link/jax/dispatch/random.py 93.96% <100.00%> (+0.16%) ⬆️

@drbenvincent
Copy link

Commenting so I get updates about the progress of this PR :)

@ricardoV94 ricardoV94 marked this pull request as draft May 21, 2024 14:38
@ricardoV94
Copy link
Member Author

I'm converting to draft because I want to see if there's another way to work with constant shapes without having to inline from the dispatch function

@ricardoV94
Copy link
Member Author

Nope this seems to be the easiest way

@ricardoV94 ricardoV94 marked this pull request as ready for review May 22, 2024 12:11
@ricardoV94 ricardoV94 merged commit bb028ae into pymc-devs:main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants