Skip to content

Conversation

Dhruvanshu-Joshi
Copy link
Member

Description

list_of_nodes and applys_between do the exact same thing i.e. extract the apply node contained between the input and output vars. Replaced all instances of list_of_nodes with applys_between.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (8c157a2) to head (8d36173).
Report is 208 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   80.85%   80.85%   -0.01%     
==========================================
  Files         162      162              
  Lines       47016    47012       -4     
  Branches    11501    11499       -2     
==========================================
- Hits        38014    38010       -4     
  Misses       6751     6751              
  Partials     2251     2251              
Files Coverage Δ
pytensor/graph/basic.py 88.90% <ø> (-0.06%) ⬇️
pytensor/scalar/basic.py 80.24% <100.00%> (ø)

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't tell if the ReadTheDocs failure could be at all related.

CC @OriolAbril

@OriolAbril
Copy link
Member

It was a spurious failure, I triggered an rebuild and it worked

@ricardoV94 ricardoV94 merged commit 880a57a into pymc-devs:main May 20, 2024
@ricardoV94
Copy link
Member

Thanks for checking it out @OriolAbril

@ricardoV94 ricardoV94 changed the title Remove list_of_nodes in favour of similar applys_between Remove list_of_nodes in favour of applys_between May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove list_of_nodes in favor of similar applys_between

3 participants