Minor: Fix dependencies #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though llvmlite is a dependency of numba, we explicitly import it, so for us it should count as a direct dependency.
maresb
added a commit
to maresb/pytensor-suite-feedstock
that referenced
this pull request
Jun 9, 2024
11 tasks
twiecki
reviewed
Jun 10, 2024
twiecki
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer depend on
typing-extensions, so let's remove it.Also, to be somewhat pedantic,
llvmliteshould be an explicit dependency under thenumbacategory.This doesn't solve any current problem, but you know me, I like to be precise about the dependencies. 😂
Related Issue
Checklist
Type of change