Add type hint None to specify_shape #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 175 175
Lines 48929 48930 +1
Branches 10395 10395
=======================================
+ Hits 36335 36336 +1
Misses 10291 10291
Partials 2303 2303
|
michaelosthege
approved these changes
Dec 10, 2022
ricardoV94
commented
Dec 10, 2022
| shape: Union[ | ||
| int, List[Union[int, Variable]], Tuple[Union[int, Variable]], Variable | ||
| ], | ||
| shape: Union[ShapeValueType, List[ShapeValueType], Tuple[ShapeValueType]], |
There was a problem hiding this comment.
The tuple probably needs ellipsis now that I think about it 🤔
There was a problem hiding this comment.
damn, you're right.
Will you take care?
Was the accidental find&replace already fixed? (let's do both in one pr)
UPDATE: I'm taking care of it while rebasing another PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstreaming aesara-devs/aesara#1313. PR port done by downstream_pr.sh script.