Skip to content

Conversation

@HangenYuu
Copy link
Contributor

@HangenYuu HangenYuu commented Jul 10, 2024

Description

Moved math and blas Ops that are currently in nlinalg.py to math.py and blas.py. Split from #878.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.36%. Comparing base (ee4d4f7) to head (1087550).
Report is 114 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/jax/dispatch/math.py 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files         171      173    +2     
  Lines       46811    46817    +6     
  Branches    11420    11420           
=======================================
+ Hits        38088    38094    +6     
+ Misses       6539     6537    -2     
- Partials     2184     2186    +2     
Files with missing lines Coverage Δ
pytensor/link/jax/dispatch/__init__.py 100.00% <100.00%> (ø)
pytensor/link/jax/dispatch/blas.py 100.00% <100.00%> (ø)
pytensor/link/jax/dispatch/nlinalg.py 100.00% <ø> (+2.22%) ⬆️
pytensor/link/jax/dispatch/math.py 93.75% <93.75%> (ø)

... and 2 files with indirect coverage changes

@HangenYuu
Copy link
Contributor Author

@ricardoV94 I would like to close this PR (#913) and #878 first before start doing my work on older issues.

@ricardoV94 ricardoV94 merged commit f35ce26 into pymc-devs:main Jul 15, 2024
@HangenYuu HangenYuu deleted the jax_link_reorg branch July 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants