Stop loop in ModbusSingleRequestHandler in server/sync.py

[Nanahara]

Hello,

Why self.running in handle function of ModbusSingleRequestHandler is not set at False on except ? If I run a ModbusSerialServer in a separate thread I cannot stop properly. And I think that the loop in serve_forever function in ModbusSerialServer is useless.

What do you think about that ?

[dhoomakethu]

Please try the fix from the dev branch and let me know if you still face any problem

[Nanahara]

Hello, I test your fix and it seems to work correctly. Thank you, Alexis 2017-08-04 7:08 GMT+02:00 dhoomakethu <notifications@github.com>:

…

Please try the fix from the dev branch and let me know if you still face any problem — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#149 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AL3pJu8PKAwmULcEmAUORGsrD2VTJb6gks5sUqc8gaJpZM4Lhd0j> .