removes undue reported error when forwarding #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf #1110 (comment) this removes the error, when running a TCP server forwarding a serial server : ``` 17:10:21 ERROR mixin:113 Please do not use unit=, convert to slave=. ````
ReadRegistersRequestBase cf ResponseBase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first commit solves a cosmetic problem mentionned in the discussion : #1110 (comment)
it removes the following undue error, reported when running a TCP server forwarding a serial server :
the second commit is a suggestion of homogeneisation in register_read_message.py