server/asyncio.py change in the _log_exception method to correct the logging when disconnecting the socket #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf #1110 (comment) this removes the error, when running a TCP server forwarding a serial server : ``` 17:10:21 ERROR mixin:113 Please do not use unit=, convert to slave=. ````
ReadRegistersRequestBase cf ResponseBase
in the _log_exception method : - all logging should be debug and not error - no logging should be thrown if the handler is not running, otherwise cancellation messages are duplicated, we see the first cancellation message at the closing stage and the same is shown when we enter the closed state this answers to #1110 (reply in thread)
janiversen
requested changes
Oct 23, 2022
pymodbus/server/async_io.py
Outdated
| def _log_exception(self): | ||
| """Show log exception.""" | ||
| if not self.running: | ||
| return |
Collaborator
There was a problem hiding this comment.
Log exception can occur before and especially after server is running.
Contributor
Author
There was a problem hiding this comment.
The _log_exception() is only called twice, in handle() when self.running is True and in connection_lost(), so always after server is running. But maybe i missunderstand something
Collaborator
There was a problem hiding this comment.
_log_exception can be called from anywhere, we add/remove _log_exception often. Apart from that it is not logical nor correct that _log_exception depends on the state of the server.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the _log_exception method :
this answers to #1110 (reply in thread)