Read device info fix #115
Merged
Read device info fix #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2016 23:41
Read Device Identification request PDU is 4 bytes: function code (0x2B), MEI type (0x0E), Read Device ID Code(0x01-0x04), and an Object ID (0x00-0xFF) RTU adds 3 bytes: 1-byte slave address, and 2-byte CRC for a total of 7 bytes on the wire. Tested against pymodbus server, as I don't have any devices that implement this code, but the data on the wire matches the expected data per the spec.
ccatterina
pushed a commit
to ccatterina/pymodbus
that referenced
this pull request
Apr 17, 2018
…fo_fix Read device info fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
_rtu_frame_sizefrom3to7to match Modbus spec.The incorrect frame size prevented the RTU framer from decoding these requests.
A Read Device Identification request is a total of 7 bytes when using the RTU protocol:
I've added a test case to the
mei_messagetests to cover this, and fixed a typo in one of the othermei_messagetests which was causing it to failThis fix has been tested against pymodbus server, as I don't have any devices that implement the MEI functions. I've verified that the data on the wire matches the expected data per the spec.