Skip to content

Fix unreachable code in AsyncModbusTcpClient #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Fix unreachable code in AsyncModbusTcpClient #1151

merged 1 commit into from
Oct 30, 2022

Conversation

@WouterTuinstra
Copy link
Contributor

@WouterTuinstra WouterTuinstra commented Oct 30, 2022

Fixes #1150 Unreachable code in else statement due to the early return in the try statement.

janiversen
janiversen approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@janiversen janiversen merged commit 20c1688 into pymodbus-dev:dev Oct 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unreachable code in AsyncModbusTcpClient

2 participants

@WouterTuinstra @janiversen