SerialServer added handle_local_echo equivalent to SerialClient #1184
Conversation
|
Please solve the CI errors, then I will review it. |
| self.timeout = kwargs.get("timeout", Defaults.Timeout) | ||
| self.device = kwargs.get("port", 0) | ||
| self.stopbits = kwargs.get("stopbits", Defaults.Stopbits) | ||
| self.handle_local_echo = kwargs.get("handle_local_echo", Defaults.HandleLocalEcho) # handle_local_echo: bool = None ; handle_local_echo: bool = Defaults.HandleLocalEcho, |
There was a problem hiding this comment.
Please remove the comment it is confusing.
| parity=self.parity, | ||
| stopbits=self.stopbits, | ||
| timeout=self.timeout, | ||
| # handle_local_echo=self.handle_local_echo, |
There was a problem hiding this comment.
What should this mean ?
|
Well I had a bit of time left, so wanted to give a hand with your errors, but you have not permitted that maintainers change the PR, so I cannot help you. |
|
Closing this commits with committer id are moved to #1186, allowing us to modify the PR. For future PRs please tick "allow maintainers to update", it makes life a lot simpler. Thanks for the PR, it makes a lot of sense, hoping to see more PRs from your hand, and good luck with your device. |
|
Thanks and sorry , I haven't made many pull requests yet, next time I will check Allow edits and access to secrets by maintainers. |
|
No problem, every beginning is difficult which is why we try to help. There are a lot to do in this project so feel free to submit more PRs, I am here if you need advice, |
2 participants
I'm working on a Device with not configurable echo on UART of RS485, and needed to implement an SerialServer, so I used
and added a new named parameter handle_local_echo like it already exists in ModbusSerialClient to solve the mass of conflikts in framing and parsing the own responses like new requests.