AsyncModbusTcp/UdpClient honors delay_ms == 0 (#1203) #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cavaler
commented
Nov 28, 2022
|
|
||
| self.connected = False | ||
| self.protocol = None | ||
| if self.params.host: |
Contributor
Author
There was a problem hiding this comment.
I don't have any UDP server, so haven't tried it
Collaborator
There was a problem hiding this comment.
I think it is covered by our test suite.
Collaborator
There was a problem hiding this comment.
and just for information, pymodbus have an excellent server, which are very good for testing cases like this.
janiversen
approved these changes
Nov 28, 2022
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
LGTM, lets see what CI says.
Collaborator
|
Thanks for the patch, would be nice if you find other things to submit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.