Skip to content

Conversation

@janiversen
Copy link
Collaborator

@janiversen janiversen commented Jan 2, 2023

100% test coverage.
Solved several problems
Added possibility for arguments in the actions
Cleaned/optimized the http_server code

add TODO.md for open simulator tasks.

@janiversen janiversen marked this pull request as draft January 3, 2023 15:00
@janiversen janiversen force-pushed the web_frontend branch 5 times, most recently from bb45320 to 16e2310 Compare January 4, 2023 09:09
@janiversen
Copy link
Collaborator Author

@dhoomakethu can you please take a fast look at the screenshot and tell me if I have covered the current functionality of the REPL server ?
I have tried to look in the source code as well as documentation, but I might have missed something.

I am currently adding the functionality behind the scenes, mainly through 2 hooks: request_tracer (new, called when entering execute) and response_manipulator (called as you know it). I am also having a student earning points while helping write some more detailed documentation.

The REPL server works without changes, as I have done all in parallel (for now).
Captura de pantalla 2023-01-04 a las 19 40 23

Thanks in advance for any comments.

@dhoomakethu
Copy link
Contributor

@janiversen guess split response is new, apart from that all other options looks good. You have it covered. Thanks

@janiversen
Copy link
Collaborator Author

Thanks, yes "split" is new, something I have wanted for a long time to test that our client can handle it.

I am nearly finished with the integration into the standard server, right now I keep it as it is, but it needs to be converted to async.

@janiversen janiversen added this to the version 3.1 milestone Jan 6, 2023
@janiversen
Copy link
Collaborator Author

@janiversen janiversen closed this Jan 12, 2023
@janiversen janiversen deleted the web_frontend branch January 12, 2023 19:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants