Fix reconnectDelay to be within (100ms, 5min) #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrudd2
force-pushed
the
reconnect-delay
branch
from
39da993 to
3ebfb0c
Compare
janiversen
approved these changes
Jan 10, 2023
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
Let's keep reconnect_delay, for 2. reasons:
- avoid a breaking API change
- when not using max, it is more logical to set reconnect_delay.
Collaborator
|
Thanks for the PR. |
alexrudd2
added a commit
to alexrudd2/pymodbus
that referenced
this pull request
Feb 21, 2023
* Fix broadCastEnable docstring * Reduce min reconnect delay to 100ms, and cap max at 5 min. Co-authored-by: jan Iversen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1243
I'm not sure if this breaks the serial code, but can't get pytest setup locally so I need to run the CI.