Added return in AsyncModbusSerialClient.connect #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
My workaround until this gets released on pip: class FixedAsyncModbusSerialClient(AsyncModbusSerialClient):
# fixme: Remove after https://github.com/pymodbus-dev/pymodbus/pull/1271 is released.
async def connect(self):
return await super().connect() or self.connected |
Collaborator
|
I expect to release v3.1.1 at the end of the month, if I can get 2 pull requests done. |
alexrudd2
pushed a commit
to alexrudd2/pymodbus
that referenced
this pull request
Feb 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncModbusSerialClient.connect is missing a return, which causes it to be unusable for
async withblocks, since the__aenter__always assumes it failed now.