Skip to content

Fix #1258 - Repl client #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix #1258 - Repl client #1288

merged 1 commit into from
Jan 24, 2023

Conversation

@dhoomakethu
Copy link
Contributor

@dhoomakethu dhoomakethu commented Jan 24, 2023

Fix #1258 Avoid showing unit as a seperate command line argument
Screenshot 2023-01-24 at 3 04 09 PM

janiversen
janiversen approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dhoomakethu dhoomakethu merged commit a779e66 into dev Jan 24, 2023
@janiversen janiversen deleted the fix-#1258 branch January 24, 2023 19:08
alexrudd2 pushed a commit to alexrudd2/pymodbus that referenced this pull request Feb 21, 2023
@dhoomakethu @alexrudd2
pymodbus-dev#1258 Avoid showing unit as a seperate command line argum…
1d67e0d 
…ent (pymodbus-dev#1288)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REPL client Remove unit argument

3 participants

@dhoomakethu @janiversen