Skip to content

Pin setuptools to prevent breakage with Version including "X" #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

Pin setuptools to prevent breakage with Version including "X" #1373

merged 1 commit into from
Feb 21, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Feb 21, 2023

Closes #1372

janiversen
janiversen approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good compromise !

@janiversen janiversen merged commit 5d7df32 into dev Feb 21, 2023
@janiversen janiversen deleted the setuptools branch February 21, 2023 18:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip install does not work with setuptools >= 66.0.0 on dev branch, since the version is non-standard

3 participants

@alexrudd2 @janiversen