Skip to content

Fix mypy errors in reactive server #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix mypy errors in reactive server #1381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdc45dd
Use a 1-item dict to keep consistent typing
alexrudd2 Feb 21, 2023
3607893
Explicitly initalize the datablock
alexrudd2 Feb 21, 2023
ac5f0dc
Merge branch 'dev' into mypy-reactive-2
janiversen Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pymodbus/server/reactive/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,11 +429,8 @@ def create_context(
range(start_address + 1, default_count), default_count - 1
)
address_map.insert(0, 0)
block[modbus_entity] = {
add: val
for add in sorted(address_map)
for val in default_values
}
address_map.sort()
block[modbus_entity] = db(address_map, default_values)
else:
block[modbus_entity] = db(start_address, default_values)

Expand All @@ -447,7 +444,7 @@ def create_context(
if not single:
slaves[i] = slave_context
else:
slaves = slave_context
slaves[0] = slave_context
server_context = ModbusServerContext(slaves, single=single)
return server_context

Expand Down