Pass remote file unit onward to Request classes #157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoomakethu
reviewed
May 21, 2017
| :param unit: | ||
| ''' | ||
| self._client = client | ||
| self.kwargs = {} |
Contributor
There was a problem hiding this comment.
we could directly create and use a class member self.unit=unit instead of this and use it directly where required. in that case default value of unit should 0 and not None
Contributor
|
@CBGoodBuddy please change the destination branch to |
dhoomakethu
added a commit
that referenced
this pull request
Oct 26, 2017
Contributor
|
will be addressed with commit 50cd952 |
dhoomakethu
added a commit
that referenced
this pull request
Oct 26, 2017
dhoomakethu
added a commit
that referenced
this pull request
Oct 26, 2017
wexi
pushed a commit
to wexi/pymodbus
that referenced
this pull request
Dec 1, 2017
dhoomakethu
added a commit
that referenced
this pull request
Dec 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch passes the ModBus unit number onward to deeper Request classes. The functionality already exists in the Request classes, so I added function to the remote classes to pass this information onward.