* register_write_message.py: Observe skip_encode option when encoding a single register request. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoomakethu
reviewed
May 29, 2017
| return struct.pack('>HH', self.address, self.value) | ||
| packet += self.value | ||
| else: | ||
| packet += struct.pack('>H', self.value) |
Contributor
There was a problem hiding this comment.
This line would throw TypeError: cannot concatenate 'str' and 'int' objects on python2 and TypeError: can't concat bytes to int on python 3.
Sorry , I used the wrong example. The code works perfectly. Updating the test code just in case .
The sample code to test this feature is below
from pymodbus.client.sync import ModbusTcpClient as ModbusClient
client = ModbusClient('127.0.0.1', port=5020)
client.connect()
address = 0x00
#client.write_register(address, 25, unit=1, skip_encode=True)
builder = BinaryPayloadBuilder(endian=Endian.Big)
builder.add_16bit_uint(0x1234)
payload = builder.build()
result = client.write_register(address, payload[0], unit=1, skip_encode=True)
result = client.read_holding_registers(address, 1, unit=1)
assert result.registers == [0x1234]
Contributor
|
please add a relevant test for your change for encode method . |
single and multiple registers.
Contributor
|
Sorry wrong PR :P |
dhoomakethu
pushed a commit
that referenced
this pull request
Nov 28, 2017
… a single register request. (#173) * * register_write_message.py: Observe skip_encode option when encoding a single register request. * Remove trailing semicolons. This isn't C. :-) * * sync.py (ModbusTcpClient.connect): `address' variable is unused. * Fix typo: controll -> control. * * test/test_register_write_messages.py: Test skip_encode when writing single and multiple registers.
ccatterina
pushed a commit
to ccatterina/pymodbus
that referenced
this pull request
Apr 17, 2018
… a single register request. (pymodbus-dev#173) * * register_write_message.py: Observe skip_encode option when encoding a single register request. * Remove trailing semicolons. This isn't C. :-) * * sync.py (ModbusTcpClient.connect): `address' variable is unused. * Fix typo: controll -> control. * * test/test_register_write_messages.py: Test skip_encode when writing single and multiple registers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.